lkml.org 
[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/37] staging:r8188eu: remove debug messages after memory allocation failed
On Wed, Oct 19, 2016 at 10:07:41PM +0700, Ivan Safonov wrote:
> These messages are redundant.
> Also break rtw_usb_if1_init function if HalData allocation failed.
>
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>

Since you're redoing this anyway, please split this one into two
patches. We really frown on mixing bugfixes with cleanups. I wasn't
frowning on it enough to ask you to redo the series but since you're
already doing that...

regards,
dan carpenter

\
 
 \ /
  Last update: 2016-10-25 11:12    [W:0.181 / U:0.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site