lkml.org 
[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] MIPS/kernel/proc: Combine four seq_printf() calls into one call in show_cpuinfo()
On Tue, Oct 25, 2016 at 10:55:42AM +0200, Geert Uytterhoeven wrote:

> > - seq_printf(m, "shadow register sets\t: %d\n",
> > - cpu_data[n].srsets);
> > - seq_printf(m, "kscratch registers\t: %d\n",
> > - hweight8(cpu_data[n].kscratch_mask));
> > - seq_printf(m, "package\t\t\t: %d\n", cpu_data[n].package);
> > - seq_printf(m, "core\t\t\t: %d\n", cpu_data[n].core);
> > + seq_printf(m,
> > + "shadow register sets\t: %d\n"
> > + "kscratch registers\t: %d\n"
> > + "package\t\t\t: %d\n"
> > + "core\t\t\t: %d\n",
> > + cpu_data[n].srsets,
> > + hweight8(cpu_data[n].kscratch_mask),
> > + cpu_data[n].package,
> > + cpu_data[n].core);
>
> I think the code is much easier to read with separate seq_printf()s for
> each line printed.

Which is why I originally implemented this as separate function calls.
Code size and performance are hardly an argument for /proc/cpuinfo.

Ralf

\
 
 \ /
  Last update: 2016-10-25 11:09    [W:0.070 / U:3.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site