Messages in this thread |  | | From | Axel Haslam <> | Date | Tue, 25 Oct 2016 10:03:44 +0200 | Subject | Re: [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node |
| |
On Tue, Oct 25, 2016 at 2:48 AM, David Lechner <david@lechnology.com> wrote: > On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: >> >> From: Axel Haslam <ahaslam@baylibre.com> >> >> This adds the usb (ohci) device node for the da850 soc. >> Also it enables it for the lcdk board >> >> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ >> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts >> index 7b8ab21..fa91339 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -86,6 +86,14 @@ >> }; >> }; >> >> +&usb_phy { >> + status = "okay"; >> +}; >> + >> +&usb { >> + status = "okay"; > > > Don't you need to specify a regulator here using the vbus-supply property?
its is not mandatory, the regulator framework is giving a dummy supply on regulator_get if it does not find a regulator on device tree. That is what i could understand from: _regulator_get in regulator/core.c
Also, in the case of platform based boot, if the board init calls regulator_has_full_constraints which is anyways needed for the phy to probe correctly it will also return a dummy regulator.
> >> +}; >> + >> &serial2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&serial2_rxtx_pins>; >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 33fcdce..ec2cec3 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -381,6 +381,14 @@ >> #phy-cells = <1>; >> status = "disabled"; >> }; >> + usb: usb@0225000 { > > > Don't need the leading 0 on usb@225000 > > The alias (usb:) might need to be more specific since there is a second usb > device that will be added later for musb. (The comments in the previous > review only referred to the "usb" in "usb@", not the alias.)
ok.
> >> + compatible = "ti,da830-ohci"; >> + reg = <0x225000 0x1000>; >> + interrupts = <59>; >> + phys = <&usb_phy 1>; >> + phy-names = "usb-phy"; >> + status = "disabled"; >> + }; >> gpio: gpio@226000 { >> compatible = "ti,dm6441-gpio"; >> gpio-controller; >> >
|  |