lkml.org 
[lkml]   [2016]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks
From
Date
On Mon, 2016-10-24 at 23:30 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
> printk messages.

trivia:

> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
[]
> @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);

you can also delete the spaces before a newline.

> return 0;
> }
>
> @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value)
> return SMU73_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);

et al, below

> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
[]
> @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
> return 0;
> }
>
> @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value)
> return SMU71_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> index 4ccc0b7..7b4efcc 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x \n", type, member);
> return 0;
> }
>
> @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value)
> return SMU7_UVD_MCLK_HANDSHAKE_DISABLE;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x \n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> index de2a24d..84868e8 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x\n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value)
> case SMU_MAX_LEVELS_MVDD:
> return SMU72_MAX_LEVELS_MVDD;
> }
> - printk("cant't get the mac value %x\n", value);
> + printk(KERN_WARNING "can't get the mac value %x\n", value);
>
> return 0;
> }

\
 
 \ /
  Last update: 2016-10-25 01:06    [W:0.449 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site