lkml.org 
[lkml]   [2016]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 01/35] media: ti-vpe: vpdma: Make vpdma library into its own module
    Hans,

    Thanks for the review.


    Hans Verkuil <hverkuil@xs4all.nl> wrote on Mon [2016-Oct-17 16:08:55 +0200]:
    > On 09/28/2016 11:16 PM, Benoit Parrot wrote:
    > > The VPDMA (Video Port DMA) as found in devices such as DRA7xx is
    > > used for both the Video Processing Engine (VPE) and the Video Input
    > > Port (VIP).
    > >
    > > In preparation for this we need to turn vpdma into its own
    > > kernel module.
    > >
    > > Signed-off-by: Benoit Parrot <bparrot@ti.com>
    > > ---
    > > drivers/media/platform/Kconfig | 6 ++++++
    > > drivers/media/platform/ti-vpe/Makefile | 4 +++-
    > > drivers/media/platform/ti-vpe/vpdma.c | 28 +++++++++++++++++++++++++++-
    > > 3 files changed, 36 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
    > > index f98ed3fd0efd..3c15c5a53bd5 100644
    > > --- a/drivers/media/platform/Kconfig
    > > +++ b/drivers/media/platform/Kconfig
    > > @@ -334,6 +334,7 @@ config VIDEO_TI_VPE
    > > depends on HAS_DMA
    > > select VIDEOBUF2_DMA_CONTIG
    > > select V4L2_MEM2MEM_DEV
    > > + select VIDEO_TI_VPDMA
    > > default n
    > > ---help---
    > > Support for the TI VPE(Video Processing Engine) block
    > > @@ -347,6 +348,11 @@ config VIDEO_TI_VPE_DEBUG
    > >
    > > endif # V4L_MEM2MEM_DRIVERS
    > >
    > > +# TI VIDEO PORT Helper Modules
    > > +# These will be selected by VPE and VIP
    > > +config VIDEO_TI_VPDMA
    > > + tristate
    > > +
    > > menuconfig V4L_TEST_DRIVERS
    > > bool "Media test drivers"
    > > depends on MEDIA_CAMERA_SUPPORT
    > > diff --git a/drivers/media/platform/ti-vpe/Makefile b/drivers/media/platform/ti-vpe/Makefile
    > > index e236059a60ad..faca5e115c1d 100644
    > > --- a/drivers/media/platform/ti-vpe/Makefile
    > > +++ b/drivers/media/platform/ti-vpe/Makefile
    > > @@ -1,6 +1,8 @@
    > > obj-$(CONFIG_VIDEO_TI_VPE) += ti-vpe.o
    > > +obj-$(CONFIG_VIDEO_TI_VPDMA) += ti-vpdma.o
    > >
    > > -ti-vpe-y := vpe.o sc.o csc.o vpdma.o
    > > +ti-vpe-y := vpe.o sc.o csc.o
    > > +ti-vpdma-y := vpdma.o
    > >
    > > ccflags-$(CONFIG_VIDEO_TI_VPE_DEBUG) += -DDEBUG
    > >
    > > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
    > > index 3e2e3a33e6ed..e55cb58213bf 100644
    > > --- a/drivers/media/platform/ti-vpe/vpdma.c
    > > +++ b/drivers/media/platform/ti-vpe/vpdma.c
    > > @@ -75,6 +75,7 @@ const struct vpdma_data_format vpdma_yuv_fmts[] = {
    > > .depth = 16,
    > > },
    > > };
    > > +EXPORT_SYMBOL(vpdma_yuv_fmts);
    >
    > EXPORT_SYMBOL_GPL?

    I think for now I would rather go for consistency.
    So I'll leave it as is.

    Regards,
    Benoit

    >
    > (Up to you).
    >
    > Regards,
    >
    > Hans

    \
     
     \ /
      Last update: 2016-10-24 18:39    [W:5.544 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site