Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM | Date | Mon, 24 Oct 2016 17:04:31 +0200 |
| |
On Thursday, October 20, 2016 3:08:14 PM CEST Nicholas Piggin wrote: > On Wed, 19 Oct 2016 16:32:00 +0100 Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > > I'm not in favour of this. > > > > +extern void mmioset(void *, unsigned int, size_t); > > +extern void mmiocpy(void *, const void *, size_t); > > + > > #ifndef __ARMBE__ > > static inline void memset_io(volatile void __iomem *dst, unsigned c, > > size_t count) > > { > > - extern void mmioset(void *, unsigned int, size_t); > > mmioset((void __force *)dst, c, count); > > } > > > > The reason they're declared _within_ memset_io() is to prevent people > > from using them by hiding their declaration. Moving them outside is > > an open invitation to stupid people starting to use them as an "oh it > > must be an official API". > >
I've split out that change from the other ones now, and will follow up with the patch to address all the other ones first.
> Fair point, what about leaving those as they are, and also adding > them to asm-prototypes.h protected with GENKSYMS ifdef? It's not > beautiful, but still better than armksyms.c before Al's patches (or > at least no worse).
I'm trying this one, and an alternative patch that moves the export into arch/arm/kernel/io.h. Let's see if we can agree on one of these.
Arnd
| |