Messages in this thread | | | From | Miklos Szeredi <> | Date | Mon, 24 Oct 2016 10:11:56 +0200 | Subject | Re: [POC/RFC PATCH] overlayfs: fix data inconsistency at copy up |
| |
On Sat, Oct 22, 2016 at 5:39 PM, Amir Goldstein <amir73il@gmail.com> wrote: > On Sat, Oct 22, 2016 at 10:24 AM, Amir Goldstein <amir73il@gmail.com> wrote: >> On Fri, Oct 21, 2016 at 11:13 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
>>> --- >>> fs/file.c | 41 +++++++++++++++++++++++++++++++++++++++++ >>> fs/overlayfs/inode.c | 1 + >>> 2 files changed, 42 insertions(+) >>> >>> Index: rhvgoyal-linux/fs/overlayfs/inode.c >>> =================================================================== >>> --- rhvgoyal-linux.orig/fs/overlayfs/inode.c 2016-10-21 15:43:05.391488406 -0400 >>> +++ rhvgoyal-linux/fs/overlayfs/inode.c 2016-10-21 16:07:57.409420795 -0400 >>> @@ -416,6 +416,7 @@ static ssize_t ovl_read_iter(struct kioc >>> if (IS_ERR(upperfile)) { >>> ret = PTR_ERR(upperfile); >>> } else { >>> + replace_file(file, upperfile);
I think it's a cool idea. But I'm not even going to look at the implementation for now, because it's such a rare corner case, that trying to optimize it should really be the last thing we do after everything else is working fine (and only if it actually turns out to be a thing that somebody actually cares about).
Thanks, Miklos
| |