Messages in this thread | | | Date | Sun, 23 Oct 2016 15:33:10 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2] x86/entry64: remove unused audit related macros |
| |
On Sun, Oct 23, 2016 at 07:14:36PM +0600, Alexander Kuleshov wrote: > These macro ocured in the 86a1c34a929f commit (x86_64 syscall audit > fast-path by Roland McGrath <roland@redhat.com>). > > These defines were used in two-phase sycalls entry tracing, but > this functionality was moved to the syscall_trace_enter() from > arch/x86/entry/common.c in the 1f484aa69 commit (x86/entry: Move > C entry and exit code to arch/x86/entry/common.c by Andy Lutomirski > <luto@kernel.org>). > > The syscall_trace_enter() now uses same defines from <linux/audit.h>, > so these defines are no longer used anywhere in entry_64.S and we may > remove them.
Good, it is getting there. Very close to what I had in mind, thanks!
Now, I went and made it a bit more readable and put the commit IDs and their names on separate lines, like we do in tip:
"These macros were added in commit
86a1c34a929f ("x86_64 syscall audit fast-path").
They were used for sycalls auditing, but this functionality was moved to the arch/x86/entry/common.c:syscall_trace_enter() in
1f484aa69046 ("x86/entry: Move C entry and exit code to arch/x86/entry/common.c")
syscall_trace_enter() now uses the same defines from <linux/audit.h>, so these defines are no longer used anywhere in entry_64.S and we may remove them."
Also, we abbreviate git commits to 12 chars. What you could do is add this to your .gitconfig:
[alias] one = show -s --pretty='format:%h (\"%s\")'
and then simply do
$ git one 1f484aa69
and it'll format it properly for ya.
Anyway, just a couple of things to pay attention to in the future.
With this, you can add
Reviewed-by: Borislav Petkov <bp@suse.de>
to your v3.
Thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |