lkml.org 
[lkml]   [2016]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/entry64: remove unused audit related macros
On Sun, Oct 23, 2016 at 12:10:32AM +0600, Alexander Kuleshov wrote:
> which are ocured in the 86a1c34a929f commit (x86_64 syscall audit
> fast-path by Roland McGrath <roland@redhat.com>) and now they are
> not used anymore.

I'd prefer it if you said which patch *removed* them and made those
defines unused again.

What would be even better is if your commit message explained *why* they
were removed in that patch and that because of <insert reason here> we
don't need them here anymore.

This should give people looking at your patch the warm and fuzzy feeling
they need in order to apply it. :-)

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.

\
 
 \ /
  Last update: 2016-10-23 09:56    [W:0.660 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site