lkml.org 
[lkml]   [2016]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] acpi/apei: Fix in-correct return value
Date
On Saturday, October 22, 2016 06:37:35 PM Borislav Petkov wrote:
> On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote:
> > Boris, all fine here?
>
> Short answer: Yeah, looks ok to me.
>
> Longer answer: I mean, this way ghes_proc() *actually* propagates the
> return value of ghes_read_estatus() and we don't do any processing if it
> failed.
>
> Which doesn't really tell me a whole lot about the actual processing,
> i.e., what ghes_do_proc() did.
>
> But ghes_do_proc() doesn't return anything and ghes_proc()'s retval is
> used only in contexts where we're asking whether something got processed
> or not.
>
> And for that, that fix is adequate. So:
>
> Reviewed-by: Borislav Petkov <bp@suse.de>

Thanks!

\
 
 \ /
  Last update: 2016-10-23 02:03    [W:0.063 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site