lkml.org 
[lkml]   [2016]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting
Date


> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com]
> Sent: Monday, October 17, 2016 5:37 PM
> To: Lipengcheng; johnyoun@synopsys.com
> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Xuejiancheng; Lidongpo; Caizhiyong; Lipengcheng
> Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting
>
>
> Hi,
>
> Pengcheng Li <lpc.li@hisilicon.com> writes:
> > The USBTRDTIM field needs to be cleared before setting a new value.
> > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
> >
> > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> > Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com>
> > Acked-by: John Youn <johnyoun@synopsys.com>
>
> which commit are you fixing? Seems like you're missing a:
>
commit c45574ff02d1d1f35a6bf4b8ad051fc06c001fc7.
> Fixes: foobar ....
>
> line here. Also, you need to remove Gerritisms from commit log ;-)
>
Ok, I will remove at the next patch.
> --
> Balbi

Best Regards
Pengcheng Li
\
 
 \ /
  Last update: 2016-10-22 03:48    [W:0.676 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site