lkml.org 
[lkml]   [2016]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: Change extern inline to static inline
On Fri, Oct 21, 2016 at 04:19:26PM +0200, Tobias Klauser wrote:
> With compilers which follow the C99 standard (like modern versions of
> gcc and clang), "extern inline" does the opposite thing from older
> versions of gcc (emits code for an externally linkable version of the
> inline function).
>
> "static inline" does the intended behavior in all cases instead.
>
> Description taken from commit 6d91857d4826 ("staging, rtl8192e,
> LLVMLinux: Change extern inline to static inline").
>
> This also fixes the following GCC warning when building with !PM:
> ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes]
>
> Fixes: d07ab6d11477 ("block: Add blk_set_runtime_active()")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>

Hehe, indeed that "extern" was probably copy pasted from the non-inline
declaration.

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

\
 
 \ /
  Last update: 2016-10-21 16:29    [W:1.365 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site