Messages in this thread | | | Subject | Re: [PATCH v2 3/4] Device bindings documentation updated ACPI-enabled platforms not currently supported | From | Andy Shevchenko <> | Date | Fri, 21 Oct 2016 13:54:32 +0300 |
| |
On Fri, 2016-10-21 at 10:56 +0100, Luis Oliveira wrote: > Since practically 90% of the code is shared between master and slave, > I was > thinking if it will be acceptable to use the same driver for both but > differentiate the master/slave mode by the compatible strings.
It might be possible to split like other drivers do:
1. Core part (i2c-designware-core.c) 2. Master part (i2c-designware-master.c) 3. Slave part (i2c-designware-slave.c) 4. Glue drivers (like: i2c-designware-platdrv.c)
> > Thanks, > Luis > > On 10/18/2016 16:17, Wolfram Sang wrote: > > > This is needed because the configuration is different and the i2c- > > > designware > > > cannot be master/slave without a reset. To resolve that I added > > > this property > > > to bind it as a slave when needed. > > > > Aww, pity that the HW can't do that. Do you have details why? > > > > If that is really a HW limitation, then I'd suggest having a > > seperate > > driver for slave-only mode so we can differentiate by compatible > > strings. > > > >
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |