[lkml]   [2016]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver
On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou
<> wrote:

> From: Georgi Vlaev <>
> This driver exports the CB FPGA presence detect bits from a
> single 32bit CB register as GPIOs.
> Signed-off-by: Georgi Vlaev <>
> Signed-off-by: Guenter Roeck <>
> [Ported from Juniper kernel]
> Signed-off-by: Pantelis Antoniou <>

This needs some more verbose commit message and explanation.

Note: GPIO = General Purpose Input/Output.

This doesn't really sound like general purpose, more like special

Consider drivers/input and drivers/connector classes for example.

> + tristate "Juniper Networks PTX1K CBC presence detect as GPIO"
> + depends on MFD_JUNIPER_CBC && OF
> + default y if JNX_CONNECTOR
> + help
> + This driver exports the CH_PRS and OTHER_CH_PRS presence detect
> + bits of the PTX1K RCB CBC FPGA as GPIOs on the relevant Juniper
> + platforms. Select if JNX_CONNECTOR is selected.
> +
> + This driver can also be built as a module. If so, the module
> + will be called gpio-cbc-presence.

At least tell us *what* it is detecting the presence of.

Apart from this it has some of the same issues pointed out in the
other drivers, correct these as well.

Linus Walleij

 \ /
  Last update: 2016-10-21 10:50    [W:0.088 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site