Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex | Date | Thu, 20 Oct 2016 11:06:58 +0200 |
| |
On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > Semaphores are going away in the future, so replace the semaphore > sync_request_sem with the a mutex lock. timeout_msecs is not used > for the lock sync_request_sem, so remove the timed locking too. > > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
The patch looks correct to me, but I think if you remove the support for handling timeouts, you should update the prototype of pqi_submit_raid_request_synchronous to no longer pass the timeout argument in the first place.
Arnd
| |