lkml.org 
[lkml]   [2016]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/37] staging:r8188eu: remove skb cloning after netdev_alloc_skb fail
On Wed, Oct 19, 2016 at 10:07:31PM +0700, Ivan Safonov wrote:
> In accordance with the KISS principle.
>

The changelog is not complete enough.

Some people are going to read only the subject, but other people are
only going to read the body of the changelog. They can be far apart
depending on how you look at patches. For example:
http://marc.info/?l=linux-driver-devel&m=147688960328996&w=2

It should say: "Just drop the packet if we can't allocate data. Don't
go to a lot of work to try recover. Let the other side resend the
data."

regards,
dan carpenter


\
 
 \ /
  Last update: 2016-10-20 10:44    [W:0.202 / U:12.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site