lkml.org 
[lkml]   [2016]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: sm750fb: Fix printk() style warning
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: printk() should include KERN_ facility level
>
> Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..e72a29c 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + pr_info("found sm750le\n");

Why can't you use dev_info() here?

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-10-02 20:13    [W:0.052 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site