lkml.org 
[lkml]   [2016]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] Staging: fbtft: Fix bug in fbtft-core
    Date
    Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug
    in fbtft-core where fps is always 0, this is because variable
    update_time is not assigned correctly.

    Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
    Fixes: 367e8560e8d7 ("Staging: fbtbt: Replace timespec with ktime_t")
    ---
    Changes in v2:
    - add Fixes tag

    drivers/staging/fbtft/fbtft-core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
    index d9046162..587f68a 100644
    --- a/drivers/staging/fbtft/fbtft-core.c
    +++ b/drivers/staging/fbtft/fbtft-core.c
    @@ -391,11 +391,11 @@ static void fbtft_update_display(struct fbtft_par *par, unsigned int start_line,

    if (unlikely(timeit)) {
    ts_end = ktime_get();
    - if (ktime_to_ns(par->update_time))
    + if (!ktime_to_ns(par->update_time))
    par->update_time = ts_start;

    - par->update_time = ts_start;
    fps = ktime_us_delta(ts_start, par->update_time);
    + par->update_time = ts_start;
    fps = fps ? 1000000 / fps : 0;

    throughput = ktime_us_delta(ts_end, ts_start);
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-10-02 17:43    [W:4.002 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site