lkml.org 
[lkml]   [2016]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()
    October 14, 2016 1:43 PM, "SF Markus Elfring" <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 14 Oct 2016 10:40:12 +0200
    >
    > Move the setting for the local variables "mask", "match" and "rc6_csl"
    > behind the source code for a condition check by this function
    > at the beginning.

    Again, I can't see what the point is?

    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/media/rc/winbond-cir.c | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
    > index fd997f0..9d05e17 100644
    > --- a/drivers/media/rc/winbond-cir.c
    > +++ b/drivers/media/rc/winbond-cir.c
    > @@ -702,17 +702,17 @@ wbcir_shutdown(struct pnp_dev *device)
    > bool do_wake = true;
    > u8 match[11];
    > u8 mask[11];
    > - u8 rc6_csl = 0;
    > + u8 rc6_csl;
    > int i;
    >
    > - memset(match, 0, sizeof(match));
    > - memset(mask, 0, sizeof(mask));
    > -
    > if (wake_sc == INVALID_SCANCODE || !device_may_wakeup(dev)) {
    > do_wake = false;
    > goto finish;
    > }
    >
    > + rc6_csl = 0;
    > + memset(match, 0, sizeof(match));
    > + memset(mask, 0, sizeof(mask));
    > switch (protocol) {
    > case IR_PROTOCOL_RC5:
    > if (wake_sc > 0xFFF) {
    > --
    > 2.10.1

    \
     
     \ /
      Last update: 2016-10-19 16:27    [W:2.881 / U:1.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site