Messages in this thread | | | Subject | Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call | From | Andy Shevchenko <> | Date | Wed, 19 Oct 2016 19:53:44 +0300 |
| |
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy.
It might be one line.
Some special references: functions: function() structs: struct my_struct
P.S. Entire series lacks of cover letter.
> > Signed-off-by: Ivan Safonov <insafonov@gmail.com> > --- > drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > index 34198fe..f19b203 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > @@ -123,7 +123,6 @@ static int recvbuf2recvframe(struct adapter > *adapt, struct sk_buff *pskb) > > pkt_copy = netdev_alloc_skb(adapt->pnetdev, > alloc_sz); > if (pkt_copy) { > - pkt_copy->dev = adapt->pnetdev; > precvframe->pkt = pkt_copy; > precvframe->rx_head = pkt_copy->data; > precvframe->rx_end = pkt_copy->data + > alloc_sz;
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |