[lkml]   [2016]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()
October 19, 2016 3:38 PM, "SF Markus Elfring" <> wrote:
>>> Move the setting for the local variables "mask", "match" and "rc6_csl"
>>> behind the source code for a condition check by this function
>>> at the beginning.
>> Again, I can't see what the point is?
> * How do you think about to set these variables only after the initial
> check succeded?

I prefer setting variables early so that no thinking about whether they're initialized or not is necessary later.

> * Do you care for data access locality?

Not unless you can show measurable performance improvements?

 \ /
  Last update: 2016-10-19 17:49    [W:0.663 / U:4.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site