lkml.org 
[lkml]   [2016]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dmaengine: st_fdma: fix uninitialized variable access
    On Wed, Oct 19, 2016 at 02:09:10PM +0200, Arnd Bergmann wrote:
    > The newly added st_fdma driver introduces a build warning for
    > allmodconfig when we add '-Wmaybe-uninitialized':
    >
    > drivers/dma/st_fdma.c: In function 'st_fdma_probe':
    > drivers/dma/st_fdma.c:777:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    >
    > The warning is correct, though this can't happen in practice
    > as the check is redundant (we don't get to this function if
    > the pointer is NULL). Even if the function were called with a
    > NULL of_node, the check is not needed because of_property_read_u32
    > can deal with a NULL argument by returning an error.
    >
    > Removing the unnecessary code simplifies the function and avoids
    > the condition that we get the warning for.

    Applied, thanks

    --
    ~Vinod

    \
     
     \ /
      Last update: 2016-10-19 16:33    [W:3.697 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site