Messages in this thread |  | | Date | Wed, 19 Oct 2016 15:54:23 +0300 | | From | Dan Carpenter <> | | Subject | Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off} |
| |
On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote: > Ok, I'll rework my patch series to stick with the direct returns. I > personally prefer that approach. I was using the gotos since I thought > that was standard convention in the kernel. >
It *should* but "goto unlock;" When you can tell what the goto does, that's great. But these gotos don't do anything so by definition the names are going to be meaningless.
regards, dan carpenter
|  |