Messages in this thread | | | Subject | Re: [PATCH 03/28] [v2] infiniband: shut up a maybe-uninitialized warning | From | Haggai Eran <> | Date | Tue, 18 Oct 2016 13:32:13 +0300 |
| |
On 10/18/2016 1:18 PM, Arnd Bergmann wrote: > On Tuesday, October 18, 2016 9:47:31 AM CEST Haggai Eran wrote: >> On 10/18/2016 1:05 AM, Arnd Bergmann wrote: >>> @@ -1309,7 +1311,7 @@ static bool validate_net_dev(struct net_device *net_dev, >>> static struct net_device *cma_get_net_dev(struct ib_cm_event *ib_event, >>> const struct cma_req_info *req) >>> { >>> - struct sockaddr_storage listen_addr_storage, src_addr_storage; >>> + struct sockaddr_storage listen_addr_storage = {}, src_addr_storage = {}; >> >> Doesn't this still translate to an extra initialization that Doug was >> worried about? > > Thanks for spotting this. I must have screwed up while rebasing the patch > at some point, this one change should not be there, the other changes by > themselves sufficiently address the warning.
Okay, other than this the patch looks good to me.
| |