lkml.org 
[lkml]   [2016]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] rtc: cmos: remove all __exit_p annotations
Hi,

On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote :
> Change since v1:
> - restored __exit for module_exit function
>
> ---8<---

I don't think this is the proper scissor symbol for git. At least, it is
no recognized by patchwork and messes your patch.

> From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Mon, 17 Oct 2016 14:17:49 +0200
> Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations
>
> I got the following stack trace under qemu:

[...]
> When cmos_set_alarm() is called dev is NULL and so trigger the deref via
> cmos->irq
>
> The problem comes from that the device is removed but no remove function
> are called due to _exit_p().
>
> This patch remove all _exit_p() annotation.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---


The changelog should go here.

> drivers/rtc/rtc-cmos.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-10-18 16:17    [W:0.034 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site