Messages in this thread | | | Subject | Re: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation | From | Pantelis Antoniou <> | Date | Mon, 17 Oct 2016 22:15:27 +0300 |
| |
Hi Ralf,
> On Oct 17, 2016, at 16:59 , Ralf Ramsauer <ralf@ramses-pyramidenbau.de> wrote: > > Hi, > > this one fixes initialisation of I2C/SPI nodes. Upon failure during > intialisation, nodes were erroneously populated and never unmarked. > > This lead to the problem that re-loaded drivers will never probe those devices > again and can easily be fixed by clearing the OF_POPULATE flag when the node > doesn't successfully initialise. > > For the discussion of v1, see > https://lkml.org/lkml/2016/10/14/483 > > Ralf > > changes since v1: > - also fix I2C core driver > - keep the atomic test-and-set, as Geert suggested > > Ralf Ramsauer (2): > spi: mark device nodes only in case of successful instantiation > i2c: mark device nodes only in case of successful instantiation > > drivers/i2c/i2c-core.c | 11 ++++++++++- > drivers/spi/spi.c | 5 ++++- > 2 files changed, 14 insertions(+), 2 deletions(-) > > -- > 2.10.1 >
Thanks for catching this.
Acked-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
| |