lkml.org 
[lkml]   [2016]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation
From
Date
Hi Ralf,

> On Oct 17, 2016, at 16:59 , Ralf Ramsauer <ralf@ramses-pyramidenbau.de> wrote:
>
> Hi,
>
> this one fixes initialisation of I2C/SPI nodes. Upon failure during
> intialisation, nodes were erroneously populated and never unmarked.
>
> This lead to the problem that re-loaded drivers will never probe those devices
> again and can easily be fixed by clearing the OF_POPULATE flag when the node
> doesn't successfully initialise.
>
> For the discussion of v1, see
> https://lkml.org/lkml/2016/10/14/483
>
> Ralf
>
> changes since v1:
> - also fix I2C core driver
> - keep the atomic test-and-set, as Geert suggested
>
> Ralf Ramsauer (2):
> spi: mark device nodes only in case of successful instantiation
> i2c: mark device nodes only in case of successful instantiation
>
> drivers/i2c/i2c-core.c | 11 ++++++++++-
> drivers/spi/spi.c | 5 ++++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> --
> 2.10.1
>

Thanks for catching this.

Acked-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>


\
 
 \ /
  Last update: 2016-10-17 21:16    [W:0.141 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site