lkml.org 
[lkml]   [2016]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 37/84] xfs: fixed signedness of error code in xfs_inode_buf_verify
    Date
    From: Jeff Mahoney <jeffm@suse.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    Prior to v3.17, XFS used positive error codes internally. Commit
    af8d971602b9583e5e8400e637e2a48c7480bc64 (xfs: inode recovery
    readahead can race with inode buffer creation), upstream commit
    b79f4a1c68bb99152d0785ee4ea3ab4396cdacc6 backported from later
    releases need the error code signs reversed. Negative error codes
    will cause assertion failures (BUG_ON on kernels with assertions
    enabled.

    Signed-off-by: Jeff Mahoney <jeffm@suse.com>
    Cc: Dave Chinner <dchinner@redhat.com>
    Cc: Brian Foster <bfoster@redhat.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    fs/xfs/xfs_inode_buf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/xfs/xfs_inode_buf.c b/fs/xfs/xfs_inode_buf.c
    index 4b1447b3a9e4..03d237a0f58b 100644
    --- a/fs/xfs/xfs_inode_buf.c
    +++ b/fs/xfs/xfs_inode_buf.c
    @@ -99,7 +99,7 @@ xfs_inode_buf_verify(
    XFS_RANDOM_ITOBP_INOTOBP))) {
    if (readahead) {
    bp->b_flags &= ~XBF_DONE;
    - xfs_buf_ioerror(bp, -EIO);
    + xfs_buf_ioerror(bp, EIO);
    return;
    }

    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-17 10:18    [W:4.123 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site