lkml.org 
[lkml]   [2016]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 32/84] clockevents: export clockevents_unbind_device instead of clockevents_unbind
    Date
    From: Vitaly Kuznetsov <vkuznets@redhat.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 32a158325acf12842764b1681f53903673f2f22e upstream.

    It looks like clockevents_unbind is being exported by mistake as:
    - it is static;
    - it is not listed in include/linux/clockchips.h;
    - EXPORT_SYMBOL_GPL(clockevents_unbind) follows clockevents_unbind_device()
    implementation.

    I think clockevents_unbind_device should be exported instead. This is going to
    be used to teardown Hyper-V clockevent devices on module unload.

    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    kernel/time/clockevents.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
    index c2eb27b6017b..054c40b3fe77 100644
    --- a/kernel/time/clockevents.c
    +++ b/kernel/time/clockevents.c
    @@ -371,7 +371,7 @@ int clockevents_unbind_device(struct clock_event_device *ced, int cpu)
    mutex_unlock(&clockevents_mutex);
    return ret;
    }
    -EXPORT_SYMBOL_GPL(clockevents_unbind);
    +EXPORT_SYMBOL_GPL(clockevents_unbind_device);

    /**
    * clockevents_register_device - register a clock event device
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-17 10:15    [W:4.038 / U:1.972 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site