lkml.org 
[lkml]   [2016]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 34/84] NFSD: Using free_conn free connection
    Date
    From: Kinglong Mee <kinglongmee@gmail.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 3f42d2c428c724212c5f4249daea97e254eb0546 upstream.

    Connection from alloc_conn must be freed through free_conn,
    otherwise, the reference of svc_xprt will never be put.

    Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    fs/nfsd/nfs4state.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
    index 0a138e4fc2e0..689595b03659 100644
    --- a/fs/nfsd/nfs4state.c
    +++ b/fs/nfsd/nfs4state.c
    @@ -2270,7 +2270,8 @@ out:
    if (!list_empty(&clp->cl_revoked))
    seq->status_flags |= SEQ4_STATUS_RECALLABLE_STATE_REVOKED;
    out_no_session:
    - kfree(conn);
    + if (conn)
    + free_conn(conn);
    spin_unlock(&nn->client_lock);
    return status;
    out_put_session:
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-17 10:14    [W:4.073 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site