lkml.org 
[lkml]   [2016]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] perf, tools: Factor out scale conversion code
Em Fri, Oct 14, 2016 at 08:45:15AM -0700, Andi Kleen escreveu:
> > So if we can't convert the scale because of an allocation failure
> > related to locale issues we silently trow it away and do no scale at
> > all?

> That is right. If your machine is thrashing to death in a OOM this
> is your smallest problem.

Please keep it was before, i.e. return an error value, and bail out. It
was like that before, why introduce these kinds of silent "do something
else in an unlikely case" handling?

- Arnaldo

\
 
 \ /
  Last update: 2016-10-14 18:17    [W:0.085 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site