lkml.org 
[lkml]   [2016]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: dynamically change verbosity level in perf top
Em Wed, Oct 12, 2016 at 11:48:22PM +0200, Alexis Berlemont escreveu:
> Hi,
>
> Here is a small patch which tries to fulfill a point in the perf todo
> list:
>
> * Make pressing 'V' multiple times to go on cycling thru various
> verbosity levels in 'perf top', so that info that is present in
> 'perf top -v' can be obtained without having to restart the tool
> (acme).
>
> After a small grep in the code, the max verbosity level seems 3; so,
> we cycle at 4; I did not dare define a MAX_VERBOSE_LEVEL constant.

Works like a charm, thanks for doing this, feel free to go over other
entries in that list :-)

I made changes only in the cset log message, adding the text you wrote
above and adding a:

Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Thanks!

- Arnaldo

> Alexis.
>
> Alexis Berlemont (1):
> perf: dynamically change verbosity level in perf top
>
> tools/perf/ui/browsers/hists.c | 5 ++++-
> tools/perf/util/map.c | 17 ++++++++++++-----
> 2 files changed, 16 insertions(+), 6 deletions(-)
>
> --
> 2.10.0

\
 
 \ /
  Last update: 2016-10-14 17:57    [W:0.076 / U:1.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site