lkml.org 
[lkml]   [2016]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/5] [media] winbond-cir: Use kmalloc_array() in wbcir_tx()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 14 Oct 2016 07:19:00 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/rc/winbond-cir.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
    index 95ae60e..59050f5 100644
    --- a/drivers/media/rc/winbond-cir.c
    +++ b/drivers/media/rc/winbond-cir.c
    @@ -660,7 +660,7 @@ wbcir_tx(struct rc_dev *dev, unsigned *b, unsigned count)
    unsigned i;
    unsigned long flags;

    - buf = kmalloc(count * sizeof(*b), GFP_KERNEL);
    + buf = kmalloc_array(count, sizeof(*b), GFP_KERNEL);
    if (!buf)
    return -ENOMEM;

    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-14 13:45    [W:4.020 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site