lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 17/18] [media] RedRat3: Adjust two checks for null pointers in redrat3_dev_probe()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 13 Oct 2016 17:40:34 +0200
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit

    The script "checkpatch.pl" pointed information out like the following.

    Comparison to NULL could be written !…

    Thus fix the affected source code places.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/rc/redrat3.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
    index 06c9eea..a09d5cb 100644
    --- a/drivers/media/rc/redrat3.c
    +++ b/drivers/media/rc/redrat3.c
    @@ -923,8 +923,7 @@ static int redrat3_dev_probe(struct usb_interface *intf,
    ep = &uhi->endpoint[i].desc;
    addr = ep->bEndpointAddress;
    attrs = ep->bmAttributes;
    -
    - if ((ep_in == NULL) &&
    + if (!ep_in &&
    ((addr & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN) &&
    ((attrs & USB_ENDPOINT_XFERTYPE_MASK) ==
    USB_ENDPOINT_XFER_BULK)) {
    @@ -935,7 +934,7 @@ static int redrat3_dev_probe(struct usb_interface *intf,
    ep_in = ep;
    }

    - if ((ep_out == NULL) &&
    + if (!ep_out &&
    ((addr & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT) &&
    ((attrs & USB_ENDPOINT_XFERTYPE_MASK) ==
    USB_ENDPOINT_XFER_BULK)) {
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-13 18:59    [W:4.015 / U:4.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site