lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 07/18] [media] RedRat3: Improve another size determination in redrat3_reset()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 13 Oct 2016 13:23:22 +0200

    Replace the specification of a data type by a pointer dereference
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/rc/redrat3.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
    index 0ac96a4..5832e6f 100644
    --- a/drivers/media/rc/redrat3.c
    +++ b/drivers/media/rc/redrat3.c
    @@ -510,7 +510,7 @@ static void redrat3_reset(struct redrat3_dev *rr3)
    struct device *dev = rr3->dev;
    int rc, rxpipe, txpipe;
    u8 *val;
    - int len = sizeof(u8);
    + size_t const len = sizeof(*val);

    rxpipe = usb_rcvctrlpipe(udev, 0);
    txpipe = usb_sndctrlpipe(udev, 0);
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-13 18:34    [W:4.027 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site