lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/18] [media] RedRat3: Use kcalloc() in two functions
    From
    Date
    On Thu, 2016-10-13 at 18:18 +0200, SF Markus Elfring wrote:
    > diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
    []
    > @@ -549,7 +549,7 @@ static void redrat3_get_firmware_rev(struct redrat3_dev *rr3)
    > int rc = 0;
    > char *buffer;
    >
    > - buffer = kzalloc(sizeof(char) * (RR3_FW_VERSION_LEN + 1), GFP_KERNEL);
    > + buffer = kcalloc(RR3_FW_VERSION_LEN + 1, sizeof(*buffer), GFP_KERNEL);
    > if (!buffer) {
    > dev_err(rr3->dev, "Memory allocation failure\n");
    > return;,

    Markus, please stop being _so_ mechanical and use your
    brain a little too. By definition, sizeof(char) == 1.

    This _really_ should be kzalloc(RR3_FW_VERSION_LEN + 1,...)

    \
     
     \ /
      Last update: 2016-10-13 18:33    [W:4.028 / U:3.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site