lkml.org 
[lkml]   [2016]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 05/18] [media] RedRat3: Delete six messages for a failed memory allocation
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 13 Oct 2016 13:20:19 +0200

    The script "checkpatch.pl" pointed information out like the following.

    WARNING: Possible unnecessary 'out of memory' message

    Thus remove such a logging statement in five functions.

    Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/rc/redrat3.c | 24 ++++++------------------
    1 file changed, 6 insertions(+), 18 deletions(-)

    diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
    index 71e901d..2e31c18 100644
    --- a/drivers/media/rc/redrat3.c
    +++ b/drivers/media/rc/redrat3.c
    @@ -453,10 +453,8 @@ static u32 redrat3_get_timeout(struct redrat3_dev *rr3)

    len = sizeof(*tmp);
    tmp = kzalloc(len, GFP_KERNEL);
    - if (!tmp) {
    - dev_warn(rr3->dev, "Memory allocation faillure\n");
    + if (!tmp)
    return timeout;
    - }

    pipe = usb_rcvctrlpipe(rr3->udev, 0);
    ret = usb_control_msg(rr3->udev, pipe, RR3_GET_IR_PARAM,
    @@ -518,10 +516,8 @@ static void redrat3_reset(struct redrat3_dev *rr3)
    txpipe = usb_sndctrlpipe(udev, 0);

    val = kmalloc(len, GFP_KERNEL);
    - if (!val) {
    - dev_err(dev, "Memory allocation failure\n");
    + if (!val)
    return;
    - }

    *val = 0x01;
    rc = usb_control_msg(udev, rxpipe, RR3_RESET,
    @@ -550,10 +546,8 @@ static void redrat3_get_firmware_rev(struct redrat3_dev *rr3)
    char *buffer;

    buffer = kcalloc(RR3_FW_VERSION_LEN + 1, sizeof(*buffer), GFP_KERNEL);
    - if (!buffer) {
    - dev_err(rr3->dev, "Memory allocation failure\n");
    + if (!buffer)
    return;
    - }

    rc = usb_control_msg(rr3->udev, usb_rcvctrlpipe(rr3->udev, 0),
    RR3_FW_VERSION,
    @@ -866,10 +860,8 @@ static struct rc_dev *redrat3_init_rc_dev(struct redrat3_dev *rr3)
    u16 prod = le16_to_cpu(rr3->udev->descriptor.idProduct);

    rc = rc_allocate_device();
    - if (!rc) {
    - dev_err(dev, "remote input dev allocation failed\n");
    + if (!rc)
    goto out;
    - }

    snprintf(rr3->name, sizeof(rr3->name), "RedRat3%s "
    "Infrared Remote Transceiver (%04x:%04x)",
    @@ -959,10 +951,8 @@ static int redrat3_dev_probe(struct usb_interface *intf,

    /* allocate memory for our device state and initialize it */
    rr3 = kzalloc(sizeof(*rr3), GFP_KERNEL);
    - if (rr3 == NULL) {
    - dev_err(dev, "Memory allocation failure\n");
    + if (!rr3)
    goto no_endpoints;
    - }

    rr3->dev = &intf->dev;

    @@ -974,10 +964,8 @@ static int redrat3_dev_probe(struct usb_interface *intf,
    rr3->ep_in = ep_in;
    rr3->bulk_in_buf = usb_alloc_coherent(udev,
    le16_to_cpu(ep_in->wMaxPacketSize), GFP_KERNEL, &rr3->dma_in);
    - if (!rr3->bulk_in_buf) {
    - dev_err(dev, "Read buffer allocation failure\n");
    + if (!rr3->bulk_in_buf)
    goto error;
    - }

    pipe = usb_rcvbulkpipe(udev, ep_in->bEndpointAddress);
    usb_fill_bulk_urb(rr3->read_urb, udev, pipe, rr3->bulk_in_buf,
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-13 18:28    [W:4.022 / U:1.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site