lkml.org 
[lkml]   [2016]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform device structure
    From
    Date
    On 2016/10/12 20:52, Paul Bolle wrote:
    > Zefan Li,
    >
    > On Wed, 2016-10-12 at 20:33 +0800, lizf@kernel.org wrote:
    >> When shutting down the device, the struct ser_cardstate must not be
    >> kfree()d immediately after the call to platform_device_unregister()
    >> since the embedded struct platform_device is still in use.
    >> Move the kfree() call to the release method instead.
    >>
    >> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
    >> Fixes: 2869b23e4b95 ("drivers/isdn/gigaset: new M101 driver (v2)")
    >> Reported-by: Sasha Levin <sasha.levin@oracle.com>
    >> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
    >> Signed-off-by: David S. Miller <davem@davemloft.net>
    >> Signed-off-by: Zefan Li <lizefan@huawei.com>
    >
    > There has been a follow up for this fix. I'll have to dive into my
    > archive to see why that was needed.
    >
    > It was complicated, because there has been a short period in which this
    > fix was correct. Something like that, I'm speaking from memory.
    > (Perhaps Tilman's memory is less imperfect.)
    >
    > I'll try get back to this shortly (in a day or so).
    >

    Thanks for looking into this.

    \
     
     \ /
      Last update: 2016-10-13 04:54    [W:2.667 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site