lkml.org 
[lkml]   [2016]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 002/125] wm831x_power: Use IRQF_ONESHOT to request threaded IRQs
    Date
    From: Valentin Rothberg <valentinrothberg@gmail.com>

    3.4.113-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit 90adf98d9530054b8e665ba5a928de4307231d84 upstream.

    Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
    threaded IRQs without a primary handler need to be requested with
    IRQF_ONESHOT, otherwise the request will fail.

    scripts/coccinelle/misc/irqf_oneshot.cocci detected this issue.

    Fixes: b5874f33bbaf ("wm831x_power: Use genirq")
    Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
    Signed-off-by: Sebastian Reichel <sre@kernel.org>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    drivers/power/wm831x_power.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/power/wm831x_power.c b/drivers/power/wm831x_power.c
    index 987332b..036ee0b 100644
    --- a/drivers/power/wm831x_power.c
    +++ b/drivers/power/wm831x_power.c
    @@ -567,7 +567,7 @@ static __devinit int wm831x_power_probe(struct platform_device *pdev)

    irq = platform_get_irq_byname(pdev, "SYSLO");
    ret = request_threaded_irq(irq, NULL, wm831x_syslo_irq,
    - IRQF_TRIGGER_RISING, "System power low",
    + IRQF_TRIGGER_RISING | IRQF_ONESHOT, "System power low",
    power);
    if (ret != 0) {
    dev_err(&pdev->dev, "Failed to request SYSLO IRQ %d: %d\n",
    @@ -577,7 +577,7 @@ static __devinit int wm831x_power_probe(struct platform_device *pdev)

    irq = platform_get_irq_byname(pdev, "PWR SRC");
    ret = request_threaded_irq(irq, NULL, wm831x_pwr_src_irq,
    - IRQF_TRIGGER_RISING, "Power source",
    + IRQF_TRIGGER_RISING | IRQF_ONESHOT, "Power source",
    power);
    if (ret != 0) {
    dev_err(&pdev->dev, "Failed to request PWR SRC IRQ %d: %d\n",
    @@ -588,7 +588,7 @@ static __devinit int wm831x_power_probe(struct platform_device *pdev)
    for (i = 0; i < ARRAY_SIZE(wm831x_bat_irqs); i++) {
    irq = platform_get_irq_byname(pdev, wm831x_bat_irqs[i]);
    ret = request_threaded_irq(irq, NULL, wm831x_bat_irq,
    - IRQF_TRIGGER_RISING,
    + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
    wm831x_bat_irqs[i],
    power);
    if (ret != 0) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-10-12 14:40    [W:4.120 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site