Messages in this thread | | | Date | Wed, 12 Oct 2016 11:08:42 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs |
| |
On 07-10-16, 16:21, Markus Mayer wrote: > +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy) > +{ > + struct private_data *priv = policy->driver_data; > + > + iounmap(priv->base); > + iounmap(priv->avs_intr_base); > + > + return 0; > +}
Shouldn't the above be done in the below routine instead ?
> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev) > +{ > + platform_set_drvdata(pdev, NULL); > + > + return cpufreq_unregister_driver(&brcm_avs_driver); > +}
-- viresh
| |