lkml.org 
[lkml]   [2016]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs
On 07-10-16, 16:21, Markus Mayer wrote:
> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy)
> +{
> + struct private_data *priv = policy->driver_data;
> +
> + iounmap(priv->base);
> + iounmap(priv->avs_intr_base);
> +
> + return 0;
> +}

Shouldn't the above be done in the below routine instead ?

> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev)
> +{
> + platform_set_drvdata(pdev, NULL);
> +
> + return cpufreq_unregister_driver(&brcm_avs_driver);
> +}

--
viresh

\
 
 \ /
  Last update: 2016-10-12 07:40    [W:0.057 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site