lkml.org 
[lkml]   [2016]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectIs conditional calling of restore_altstack() correct for ARC
Date
Hi Al,

I spotted a possible anomaly with ARC sigaltstack() handling and was wondering if
you could confirm if it was wrong (I don't have a test case to prove one way or
the other).

We have a micro-optimization which elides calling restore_altstack() in sigreturn
path, based on a "magic" value, set at the time of sigaction (SA_SIGINFO). So
essentially we only restore ss_{sp,size,flags} if SA_SIGINFO was set.

Do you think this needs to be done unconditionally like other ports do ?

Thx,
-Vineet


\
 
 \ /
  Last update: 2016-10-11 20:06    [W:0.024 / U:2.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site