Messages in this thread | | | Date | Mon, 10 Oct 2016 22:31:04 -0300 | From | Sergio Prado <> | Subject | Re: [PATCH 3/3] mtd: s3c2410: parse the device configuration from OF node |
| |
On Fri, Oct 07, 2016 at 07:28:10PM +0300, Krzysztof Kozlowski wrote:
> > +struct s3c24XX_nand_devtype_data { > > + enum s3c_cpu_type type; > > +}; > > + > > +struct s3c24XX_nand_devtype_data s3c2410_nand_devtype_data = { > > + .type = TYPE_S3C2410, > > +}; > > + > > +struct s3c24XX_nand_devtype_data s3c2412_nand_devtype_data = { > > + .type = TYPE_S3C2412, > > +}; > > + > > +struct s3c24XX_nand_devtype_data s3c2440_nand_devtype_data = { > > + .type = TYPE_S3C2440, > > +}; > > + > > +struct s3c24XX_nand_devtype_data s3c6400_nand_devtype_data = { > > + .type = TYPE_S3C2412, > > All of these look like candidate for static const. > > Additionally you are not actually differentiating between s3c2412 and > s3c64xx so I think there is not need of samsung,s3c6400-nand compatible. > Just use existing one. > > Best regards, > Krzysztof
You are right. I'll review and send V2.
Best regards,
Sergio Prado
| |