lkml.org 
[lkml]   [2016]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 08/15] md-cluster: Improve determination of sizes in read_resync_info()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 1 Oct 2016 12:52:58 +0200

    Replace the specification of data structures by either a pointer
    dereference or a variable name as the parameter for the operator "sizeof"
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/md-cluster.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
    index e965e78..0918108 100644
    --- a/drivers/md/md-cluster.c
    +++ b/drivers/md/md-cluster.c
    @@ -275,10 +275,10 @@ static struct suspend_info *read_resync_info(struct mddev *mddev, struct dlm_loc
    sector_t hi = 0;

    dlm_lock_sync(lockres, DLM_LOCK_CR);
    - memcpy(&ri, lockres->lksb.sb_lvbptr, sizeof(struct resync_info));
    + memcpy(&ri, lockres->lksb.sb_lvbptr, sizeof(ri));
    hi = le64_to_cpu(ri.hi);
    if (hi > 0) {
    - s = kzalloc(sizeof(struct suspend_info), GFP_KERNEL);
    + s = kzalloc(sizeof(*s), GFP_KERNEL);
    if (!s)
    goto out;
    s->hi = hi;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-10-01 16:54    [W:4.018 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site