lkml.org 
[lkml]   [2016]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data
Date
Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Sat, Jan 9, 2016 at 3:22 AM, Mans Rullgard <mans@mansr.com> wrote:
>> As struct mci_dma_data is now only used by AVR32, it is nothing but
>> pointless indirection. Replace it with struct dw_dma_slave in the
>> AVR32 platform code and with a void pointer elsewhere.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>
>> @@ -1376,15 +1375,15 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
>> ARRAY_SIZE(atmel_mci0_resource)))
>> goto fail;
>>
>> - slave = kzalloc(sizeof(struct mci_dma_data), GFP_KERNEL);
>> + slave = kzalloc(sizeof(*slave), GFP_KERNEL);
>> if (!slave)
>> goto fail;
>>
>> - slave->sdata.dma_dev = &dw_dmac0_device.dev;
>> - slave->sdata.src_id = 0;
>> - slave->sdata.dst_id = 1;
>> - slave->sdata.m_master = 1;
>> - slave->sdata.p_master = 0;
>
> Seems you based this on top of our non-submitted yet patches.

You're right. I didn't realise this file had been touched by those
patches, and I didn't read the code all that carefully when making this
change.

>> + slave->dma_dev = &dw_dmac0_device.dev;
>> + slave->src_id = 0;
>> + slave->dst_id = 1;
>> + slave->m_master = 1;
>> + slave->p_master = 0;
>
> --
> With Best Regards,
> Andy Shevchenko

--
Måns Rullgård

\
 
 \ /
  Last update: 2016-01-09 13:41    [W:0.077 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site