lkml.org 
[lkml]   [2016]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 03/19] bluetooth: hci_ldisc: Remove dead code
    Date
    The N_HCI ldisc does not define a flush_buffer() ldisc method, so
    the check when opening the ldisc is always false.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/bluetooth/hci_ldisc.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
    index 96bcec5..c303f87 100644
    --- a/drivers/bluetooth/hci_ldisc.c
    +++ b/drivers/bluetooth/hci_ldisc.c
    @@ -461,13 +461,7 @@ static int hci_uart_tty_open(struct tty_struct *tty)
    INIT_WORK(&hu->init_ready, hci_uart_init_work);
    INIT_WORK(&hu->write_work, hci_uart_write_work);

    - /* Flush any pending characters in the driver and line discipline. */
    -
    - /* FIXME: why is this needed. Note don't use ldisc_ref here as the
    - open path is before the ldisc is referencable */
    -
    - if (tty->ldisc->ops->flush_buffer)
    - tty->ldisc->ops->flush_buffer(tty);
    + /* Flush any pending characters in the driver */
    tty_driver_flush_buffer(tty);

    return 0;
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-01-10 06:21    [W:4.078 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site