Messages in this thread | | | Date | Fri, 8 Jan 2016 15:06:35 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar |
| |
On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote: > Hi Phil, > > On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote: > > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource > > with global function pointer") removed the struct pci_sys_data > > dependency from the ARM pcibios functions, so remove it from this > > driver. > > I am a little confused by this as I still see two instances of > the following in bios32.c as of the commit above. > > struct pci_sys_data *sys = dev->sysdata;
This patch only removes a pci_sys_data struct from pcie-rcar.c. That struct was previously used by pci_common_init_dev() and by the ARM pcibios_align_resource().
After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29, ARM doesn't need pci_sys_data for pcibios_align_resource().
Phil can correct me if I'm wrong, but I think this patch is probably OK. I guess we can tell after I apply it and get a build test :)
Bjorn
| |