lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] acpi: avoid leaking format string into kobject name
Date
On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote:
> The dn->name is expected to be used as a literal, so add the missing
> "%s".
>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied, thanks!

> ---
> drivers/acpi/device_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 707cf6213bc2..b9afb47db7ed 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
>
> init_completion(&dn->kobj_done);
> ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
> - kobj, dn->name);
> + kobj, "%s", dn->name);
> if (ret)
> acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
> else
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

\
 
 \ /
  Last update: 2016-01-08 02:01    [W:0.049 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site