lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/5] test: firmware_class: report errors properly on failure
    From
    Date
    On 12/09/2015 03:50 PM, Brian Norris wrote:
    > request_firmware() failures currently won't get reported at all (the
    > error code is discarded). What's more, we get confusing messages, like:
    >
    > # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
    > [ 8280.311856] test_firmware: loading 'notafile'
    > [ 8280.317042] test_firmware: load of 'notafile' failed: -2
    > [ 8280.322445] test_firmware: loaded: 0
    > # echo $?
    > 0
    >
    > Report the failures via write() errors, and don't say we "loaded"
    > anything.
    >
    > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    > Acked-by: Kees Cook <keescook@chromium.org>

    Thanks for fixing it. Applied to linux-kselftest next for 4.5-rc1.

    -- Shuah


    --
    Shuah Khan
    Sr. Linux Kernel Developer
    Open Source Innovation Group
    Samsung Research America (Silicon Valley)
    shuahkh@osg.samsung.com | (970) 217-8978

    \
     
     \ /
      Last update: 2016-01-07 22:41    [W:4.151 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site