Messages in this thread | | | Subject | Re: net-thunder: One check less in nicvf_register_interrupts() after error detection | From | Joe Perches <> | Date | Thu, 07 Jan 2016 12:28:50 -0800 |
| |
On Thu, 2016-01-07 at 21:07 +0100, SF Markus Elfring wrote: > > > * Which object code representations would you find representative > > > for a further constructive discussion around this > > > software component? > > > > Evidence of actual object code improvement > > How do you think about to provide a function implementation > which looks a bit more efficient by default?
It's not a matter of "looks a bit more efficient". it's taste, style, and repetition for various functions.
Some prefer that source code be "templatized" regardless of the number of exit points that any particular use of a specific function type.
Some of your patches are converting these templatized functions to a different form for no added value.
These patches make the local source code inconsistent and generally goes against the authors preferred style.
| |