lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver
From
Date
Hi Boris,

>> If AIC and AIC5 must be separate, then I'll try to rework
>> irq-atmel-common part.
>
> What would you like to rework? Could you describe in more details
> what's bothering you in this code?

I was about to modify irq-atmel-aic-common as below.

* AIC5 handles for-loop twice during initialization.
1) after IRQ generic chip is allocated successfully.
2) map AIC5 IRQ chip operation after aic_common_of_init() returns.
To reduce for-loop count, move each IRQ chip initialization code into
common part.

* AIC and AIC5 have same interrupt handling procedure, so each IRQ
handler can be moved to common part.

BTW, I've sent another patch-set about fixing few things. Could you
check them?

Best regards,
Milo


\
 
 \ /
  Last update: 2016-01-07 09:21    [W:0.071 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site