lkml.org 
[lkml]   [2016]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v11 3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes
Hi Harvey + Ralf,

On Thu, Jan 07, 2016 at 09:40:13AM +0000, Harvey Hunt wrote:
> On 07/01/16 01:29, Brian Norris wrote:
> >On Mon, Jan 04, 2016 at 12:34:44PM +0000, Harvey Hunt wrote:
> >>diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> >>index 9fcb9e7..782258c 100644
> >>--- a/arch/mips/boot/dts/ingenic/ci20.dts
> >>+++ b/arch/mips/boot/dts/ingenic/ci20.dts
> >
> >As I noted on patch 1, you need to send this to linux-mips + Ralf.
>
> I forgot to CC Ralf on this version, but he took v9 (no change
> between v9 and v11) through linux-mips as can be seen here:
> http://patchwork.linux-mips.org/patch/11695/

OK.

> >>@@ -42,3 +42,66 @@
> >> &uart4 {
> >> status = "okay";
> >> };
> >>+
> >>+&nemc {
> >>+ status = "okay";
> >>+
> >>+ nandc: nand-controller@1 {
> >>+ compatible = "ingenic,jz4780-nand";
> >>+ reg = <1 0 0x1000000>;
> >>+
> >>+ #address-cells = <1>;
> >>+ #size-cells = <0>;
> >>+
> >>+ ingenic,bch-controller = <&bch>;
> >>+
> >>+ ingenic,nemc-tAS = <10>;
> >>+ ingenic,nemc-tAH = <5>;
> >>+ ingenic,nemc-tBP = <10>;
> >>+ ingenic,nemc-tAW = <15>;
> >>+ ingenic,nemc-tSTRV = <100>;
> >>+
> >>+ nand@1 {
> >>+ reg = <1>;
> >>+
> >>+ nand-ecc-step-size = <1024>;
> >>+ nand-ecc-strength = <24>;
> >>+ nand-ecc-mode = "hw";
> >>+ nand-on-flash-bbt;
> >>+
> >>+ partitions {
> >>+ #address-cells = <2>;
> >>+ #size-cells = <2>;
> >
> >This binding was updated, so you need:
> >
> > compatible = "fixed-partitions";
>
> This has been fixed in mips-linux here:
> http://patchwork.linux-mips.org/patch/11914/

Ralf: it looks like you applied the DTS changes twice, essentially.
Might want to fix that:

[From arch/mips/boot/dts/ingenic/ci20.dts]
...
&nemc {
...
nandc: nand-controller@1 {
...
nand@1 {
...
partitions {
compatible = "fixed-partitions";
...
};
};
};
};

&bch {
status = "okay";
};
&nemc {
...
nandc: nand-controller@1 {
...
nand@1 {
...
partitions {
...
};
};
};
};
&bch {
status = "okay";
};

Brian


\
 
 \ /
  Last update: 2016-01-07 19:01    [W:1.551 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site